Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Docker support for the Lagrange.Milky application, enabling containerized deployment with multi-architecture builds (amd64 and arm64).
- Adds a multi-stage Dockerfile using AOT compilation to create a minimal static executable
- Configures InvariantGlobalization in the project file to support static AOT compilation
- Implements a GitHub Actions workflow for building and pushing multi-platform Docker images to GHCR
- Adds .dockerignore to optimize build context
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Lagrange.Milky/Resources/Dockerfile | Multi-stage Dockerfile that builds the application using .NET SDK 10.0 Alpine and deploys to a scratch image for minimal footprint |
| Lagrange.Milky/Lagrange.Milky.csproj | Enables InvariantGlobalization to support fully static AOT compilation without ICU dependencies |
| .github/workflows/milky-docker.yaml | Implements multi-platform Docker build workflow with digest-based image creation for amd64 and arm64 architectures |
| .github/workflows/milky-build.yaml | Minor whitespace cleanup (trailing whitespace removal) |
| .dockerignore | Defines Docker build context exclusions, whitelisting only necessary project directories and excluding build artifacts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.